tengattack / certbot-dns-dnspod

A certbot dns plugin to obtain certificates using dnspod.
Other
65 stars 18 forks source link

Fix error while add_txt_record. #3

Closed huww98 closed 6 years ago

huww98 commented 6 years ago

I got error when trying to obtain certification.

Unexpected error determining zone identifier for cn: Domain name invalid, please input tld domain

I have fixed this

tengattack commented 6 years ago

But if we try to obtain certification for sub domain like foo.bar.example.com, will it work?

huww98 commented 6 years ago

I think it will work.

https://github.com/certbot/certbot/blob/v0.26.1/certbot/plugins/dns_common.py#L326-L327

It will try every possible domain.

tengattack commented 6 years ago

Are you trying to obtain certification for top-level domain like foo.cn?

huww98 commented 6 years ago

Yes

tengattack commented 6 years ago

OK thank you!

huww98 commented 6 years ago

I have just tested that it does not work for something like foo.bar.example.com, I will trying to figure out why.

tengattack commented 6 years ago

Maybe we should determine whether the domain is top-level domain or not

huww98 commented 6 years ago

Fixed that. I have successfully obtained a certification for foo.bar.<mydomain>.con

tengattack commented 6 years ago

Great works!