tengcharmaine / pe

0 stars 0 forks source link

Adding of additional parameters #8

Open tengcharmaine opened 5 months ago

tengcharmaine commented 5 months ago

Screenshot 2024-04-19 at 4.42.26 PM.png

I tried adding another prefix p/ initially but your group managed to check for that which i thought was good! But after changing it to a parameter that is not in the add command (ppp/) it gives me an error saying that a phone number should be at least 3 digits long. This error message not really correct? And also the fact that the error message is not invalid command it means that the command was accepted by your app which may confuse some users.

nus-pe-script commented 5 months ago

Team's Response

Thank you for pointing this out. However, from our UG, it is clear that ppp/ is not a valid field. As such the entire string "98765432 ppp/" is considered as part of the phone number input. The validator thus correctly identifies that there are invalid characters, like alphabets, in the string, thus rejecting it as an input and gives an error message about the phone number's input type. We thus classify this as out of scope as while it is possible to improve the validator to identify that this is an invalid command issue, thus giving a more precise error message, but it is less important than the current work of adding more important commands and validating the actual inputs of each field.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]