search

tengen-io / server

:white_circle: Server implementation of the board game Go
MIT License
13 stars 4 forks source link

Add a link to the GraphiQL browser on the homepage #39

Closed jish closed 5 years ago

jish commented 5 years ago

Currently when loading the server in development an empty 404 page is rendered. This is confusing to new developers as they are unsure if the server is working properly, and if it is working properly, there is no guidance as to what to do with the server.

Before

screen shot 2019-02-23 at 3 10 35 pm

After

screen shot 2019-02-23 at 3 07 03 pm
jish commented 5 years ago

The GraphiQL link only shows up in the "development" environment:

$ go build
$ GO_ENV=production ./go_stop
screen shot 2019-02-24 at 7 42 16 pm

There are a few housekeeping and cleanup commits that were necessary, but this commit is the one that actually implements the hiding logic: https://github.com/camirmas/go-stop-go/pull/39/commits/caabd8100c0df68e588c3ca43bd09f42bcb1aec1

camirmas commented 5 years ago

Also, this resolves #26. Nice work!