Fix/incorrect usage of @cvrg report/jacoco json

tenninebt / vscode-koverage

VSCode code coverage extension

Apache License 2.0

26 stars 6 forks source link

Fix/incorrect usage of @cvrg report/jacoco json #34

Closed GV94 closed 1 year ago

GV94 commented 1 year ago

Fixes #33

If this PR is merged, it will:

Fix incorrect usage of @cvrg-report/jacoco-json
Refactor xmlExtractJacoco to use async/await

tenninebt commented 1 year ago

The PR is obsolete (sorry had to force push the repo today, a clean up script on my side messed up things.) Would you be able to re-fork and create a new PR ? (I can also have a look at your forks commits and report the change myself but I'm trying not take credit for your work 🙂)

GV94 commented 1 year ago

Hey, sure, I'll get something up during the week

GV94 commented 1 year ago

Hey, it looks like the version of the repo that you force pushed does not suffer from the bug that it did before the force push. So there is no need for the change I had in my PR. It's just the conversion to async/await. I guess I could do that change if you want me to. Let me know in that case.