search

tenodi / permission

Npm package for hangling user permissions for routes based on roles.
https://www.npmjs.com/package/permission
MIT License
72 stars 22 forks source link

Allow the req.user[role] to be an array of roles #5

Closed czytelny closed 7 years ago

czytelny commented 7 years ago

Hi, nice lib - perfectly fit my needs:) would you mind to merge this pull request to master? perhaps it solves issue #3

BenoitRanque commented 7 years ago

Hello @czytelny

Seeing as @tenodi seems inactive, could you publish this fork on npm under a different name? I want to use it for a project I am working on, but cannot include it in my package.json without it being published.

P.S. Hurray for my first comment on GitHub!

P.P.S. I could publish it myself but it is your work. Still not sure how the etiquette works when it comes to these matters

czytelny commented 7 years ago

Hi @BenoitRanque in that case you can use direct link to my fork in your package.json:

"dependencies": {
    "permission": "git://github.com/czytelny/permission.git"
}

my change is also rather tiny, so i don't want to make separate npm entry only for that :)

BenoitRanque commented 7 years ago

@czytelny Thank you! Exactly the information I needed

Thanks again

Edit: install with npm: npm install --save git://github.com/czytelny/permission.git

npm install --save czytelny/permission

Generate package.json:

"dependencies": { "permission": "github:czytelny/permission" }

tenodi commented 7 years ago

Hi, @czytelny. As I'm short on time, I invited you as a collaborator to this project.

BenoitRanque commented 7 years ago

My fork gets rid of the passport.js dependency, if anyone is interested.

tenodi commented 7 years ago

@BenoitRanque I gave you collaborator access as well. So, if this is something that you think is needed, feel free to contribute directly and assign someone to PR.

BenoitRanque commented 7 years ago

Thank you. My fork differs in that I got rid of the passport dependency. So will keep separate.

On May 22, 2017 17:50, "Tomislav Tenodi" notifications@github.com wrote:

@BenoitRanque https://github.com/benoitranque I gave you collaborator access as well. So, if this is something that you think is needed, feel free to contribute directly and assign someone to PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tenodi/permission/pull/5#issuecomment-303229578, or mute the thread https://github.com/notifications/unsubscribe-auth/AYhZPkLM2kIH7YpN4xWwJNorKnfkJcBEks5r8gMLgaJpZM4Lwe2w .

czytelny commented 7 years ago

thanks! I was on holiday ;) i'll take a look on the weekend and try to push things further.