arguments broken

[tenox7]

paging @MIvanchev https://github.com/tenox7/ttyplot/pull/90 broke aruments/flags (update: for bsd/macos only), can you please fix?

[edgar-bonet]

I cannot reproduce:

$ git switch master
Already on 'master'
Your branch is up to date with 'upstream/master'.
$ git pull upstream
Already up to date.
$ git clean -dxf  # make this as clean as it gets
Removing ttyplot
$ make
cc -Wall -Wextra    ttyplot.c  `pkg-config --libs ncurses 2>/dev/null || echo '-lcurses -ltinfo'` -o ttyplot
$ ./ttyplot -v
ttyplot 1.5.1
$ ./ttyplot -h
Usage:
  ttyplot [-h] [-v] [-2] [-r] [-c plotchar] [-s scale] [-m max] [-M min] [-t title] [-u unit]

  -2 read two values and draw two plots, the second one is in reverse video
  [snip]
$ seq 1 80 | ./ttyplot -c o
# A plot is displayed with the ‘o’ character.
$ lsb_release -ds
Ubuntu 22.04.3 LTS

[MIvanchev]

I can't reproduce either,

git checkout 1.5.1
rm ttyplot && make
seq 1 80 | ./ttyplot -c o -m 40 -t "I ain't scared of no ghosts." -u ghosts

Works great!

[hartwork]

@tenox7 can you define broken and share more about the environment? E.g. is it a box with ancient broken getopt by any chance?

[MIvanchev]

It could be that optind needs to be reset to 1 instead of 0.

[MIvanchev]

@tenox7 (and everyone else): Could you check if this MR works for you? If yes, I also incremented the version numbers for a hotfix release.

[tenox7]

haha, no the issue is on latest freebsd and macos; build from head master and ran with -2, still only shows one chart, -c and others do not work

[tenox7]

tried https://github.com/MIvanchev/ttyplot/tree/issue-102-potentially-incorrect-usage still same issue, both freebsd and macos

[MIvanchev]

@tenox7 OK, I know what the issue is, stand by.

[tenox7]

thank you :)

[MIvanchev]

@tenox7 Try now? I've added some BSD and Mac logic.

[tenox7]

checking (thank you!)

[tenox7]

same repo? just did git clone https://github.com/MIvanchev/ttyplot.git && cd ttyplot && make ttyplot && ./ttyplot -2

linux: works freebsd: doesnt macos: doesnt

[MIvanchev]

git clone --branch issue-102-potentially-incorrect-usage https://github.com/MIvanchev/ttyplot.git && cd ttyplot && make ttyplot && ./ttyplot -2

[tenox7]

wait I guess I forgot to switch the branch

[tenox7]

ok branch remotes/origin/issue-102-potentially-incorrect-usage works!

linux: works macos: works freebsd: works

thank you! please send a PR

[MIvanchev]

It's here https://github.com/tenox7/ttyplot/pull/103, good thing you test on non Linuxes :))

P.S. I'll research how to set automated tests for that.

P.S.S. Versions numbers are adjusted for 1.5.2 if you decide to hotfix immediately.

[tenox7]

thank you for fixing @MIvanchev much appreciated!!!!

[MIvanchev]

NP, this is a small one, much more work to be done.

[hartwork]

FYI pull request https://github.com/Homebrew/homebrew-core/pull/154651 by @Porkepix will get 1.5.2 with the fix into homebrew for macOS. OpenBSD with current 1.5.1 is also affected. Is anyone in touch with them on the topic already?

[hartwork]

@fcambus any chance you could bump ttyplot to 1.5.2 to fix issue https://github.com/tenox7/ttyplot/issues/102#issuecomment-1814217694 for users of OpenBSD?

[fcambus]

@fcambus any chance you could bump ttyplot to 1.5.2 to fix issue #102 (comment) for users of OpenBSD?

I just committed an update, thanks for the heads-up!

[hartwork]

@fcambus excellent, thank you! :+1: