search

tenox7 / ttyplot

a realtime plotting utility for terminal/console with data input from stdin
Apache License 2.0
956 stars 42 forks source link

Add support for negative values #153

Closed gsmecher closed 5 months ago

gsmecher commented 6 months ago

Adds support for negative values. Should clear up #53 and #22.

This is a quick and possibly rough implementation - comments welcome.

gsmecher commented 6 months ago

@gsmecher I haven't looked at this in detail yet but I should share that @tenox7 and @edgar-bonet and I are in the process of finishing release 1.6.0 based off branch development not master, ticket #134 has a few details more, we're not far from the finish line (..). It is probably best to get 1.6.0 finished and development merged into master first and then we can see together how to transplant this new support for negative numbers, some of it may already by there from #115 but I haven't had a closer look yet what's in here. Happy to do that after 1.6.0.

Not a problem - this was a quick first run through negative-value support. If you get there first, great - otherwise I'll look at merging or rewriting post-1.6.0.

hartwork commented 6 months ago

@gsmecher with #155 merged, master would now be ready for a re-evaluation of support for negative values.

tenox7 commented 6 months ago

It says there are conflicts in Makefile and ttyplot.c

hartwork commented 5 months ago

@gsmecher with #155 merged, master would now be ready for a re-evaluation of support for negative values.

@gsmecher we haven't heard from you for 3+ weeks now. Are you still interested in this pull request?

gsmecher commented 5 months ago

I am! My apologies - I'm swamped. I'll find some time soon.

On Thu, Jan 18, 2024, 5:19 p.m. Sebastian Pipping @.***> wrote:

@gsmecher https://github.com/gsmecher with #155 https://github.com/tenox7/ttyplot/pull/155 merged, master would now be ready for a re-evaluation of support for negative values.

@gsmecher https://github.com/gsmecher we haven't heard from you for 3+ weeks now. Are you still interested in this pull request?

— Reply to this email directly, view it on GitHub https://github.com/tenox7/ttyplot/pull/153#issuecomment-1899481875, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEU5DF5CO4TQI42SUC4L3DYPHC37AVCNFSM6AAAAABAXCY7QWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGQ4DCOBXGU . You are receiving this because you were mentioned.Message ID: @.***>

gsmecher commented 5 months ago

Closed in favour of #169.