search

tenox7 / ttyplot

a realtime plotting utility for terminal/console with data input from stdin
Apache License 2.0
956 stars 42 forks source link

Add support for negative values #169

Closed gsmecher closed 1 month ago

gsmecher commented 5 months ago

This is an updated version of #153, and should clear up https://github.com/tenox7/ttyplot/issues/53 and https://github.com/tenox7/ttyplot/issues/22.

This is a quick and possibly rough implementation - comments welcome. The rebase looks clean enough, but I admit to rushing through it.

hartwork commented 5 months ago

@gsmecher just a quick note that with the next push your CI here will be red due to meantime changes at https://apt.llvm.org/ unless you rebase onto latest master where pull request #170 with a fix has been merged. Thanks!

gsmecher commented 5 months ago

@gsmecher just a quick note that with the next push your CI here will be red due to meantime changes at https://apt.llvm.org/ unless you rebase onto latest master where pull request #170 with a fix has been merged. Thanks!

Thanks - I have rebased and force-pushed, removing the bogus array size check at the same time.

edgar-bonet commented 5 months ago

@gsmecher: There is something wrong with your last force-push. The previous one (77fb446) was, as expected, based on master. The last one (3d83c57) is based on master~ and carries copies of the two commits of #170, with different Committer name:

* 3d83c57 (pull/169/head) Add support for negative values.
* 622f3a9 stresstest: add -n flag to remove positive bias (emit negative values)
* 6d24924 Don't use FLT_MIN - 0 is the correct value here.
* 1c579ef linux_and_macos.yml: Drop compilation with Clang 17
* bb6a97d linux_and_macos.yml: Get installation of Clang 18 on Linux back in sy>
* 5b64245 Move global variables that are only locally used into local scope.
| * 77fb446 Add support for negative values.
| * 0f1ae18 stresstest: add -n flag to remove positive bias (emit negative valu>
| * 216be4a Don't use FLT_MIN - 0 is the correct value here.
| * 0eb1356 Move global variables that are only locally used into local scope.
| * f98f2f2 (master) Merge pull request #170 from hartwork/fix-linux-ci
|/| 
| * 321ebd5 linux_and_macos.yml: Drop compilation with Clang 17
| * aef9d29 linux_and_macos.yml: Get installation of Clang 18 on Linux back in >
|/  
* 374bca3 readme update

Also, I had to unresolve a couple of review comments.

gsmecher commented 5 months ago

My apologies. I am trying to keep this as a "side distraction" - which isn't fair if it pushes work onto you.

I have rebased onto f98f, and can see the correct commit history since then. I'll force-push that now, then look into the resolved/unresolved comments. Thanks for bearing with me.

tenox7 commented 3 months ago

Do you want me to merge?

edgar-bonet commented 3 months ago

Do you want me to merge?

Yes please. I would rather let you have the final call.

tenox7 commented 1 month ago

Thank you!