search

tenox7 / ttyplot

a realtime plotting utility for terminal/console with data input from stdin
Apache License 2.0
961 stars 43 forks source link

Implemented hardmin feature #47

Closed hrshbh closed 3 years ago

hrshbh commented 4 years ago

Implemented the hardmin feature, as requested in issue #42 and issue #22 , along with other minor improvements. softmin not implemented.

tenox7 commented 4 years ago

Very nice! However you have also made some changes that do not concern hardmin feature. This makes it hard to read. Please split this PR in to smaller ones so that they can be addressed in a more granular meaner. Thank you!

hrshbh commented 4 years ago

Done. Now all changes strictly concern with hardmin.

tenox7 commented 4 years ago

I would also like the other changes, just in a separate PR. Thank you!

hrshbh commented 4 years ago

I agree, I was sloppy about the usage() and the manpage. I've tried to make them better, but if still changes are required in them, then I think you can amend it here before merging.

Regarding the softmin matter, I have added checks after parsing of args.

And as to the error response of value being less than hardmin, I was thinking of making as little changes as possible to the code, as it was beautiful already. Now, I've added a new error symbol, and included option to modify it.

tenox7 commented 3 years ago

Hi, why did you close this? I would really like to get min/hardmin in to ttyplot.

hrshbh commented 3 years ago

Hi, the PR was in the open state for quite some time, without any response. So, I decided to close it. Should I reopen this? It's been almost a year, probably there will be some merge conflicts that will need to be resolved first.

tenox7 commented 3 years ago

I really want to have it so I guess reopen it?

hrshbh commented 3 years ago

Thanks for the interest. Will soon work to resolve the merge conflicts, if any.

tenox7 commented 3 years ago

thanks! let me try it!

tenox7 commented 3 years ago

Merged thank you very much!