error: format not a string literal and no format arguments

kseistrup commented 1 year ago

Commit 71d4aa7120f540b453f5c4d0ba7c464df74c4137 will not compile with -Werror=format-security because the error string does not have any formatting and no format arguments are given to mvprintw():

gcc -march=x86-64 -mtune=native -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -flto=auto -Wall -Wextra -D_FORTIFY_SOURCE=2 -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -flto=auto  ttyplot.c  -lcurses -ltinfo -o ttyplot
ttyplot.c: In function ‘main’:
ttyplot.c:318:13: error: format not a string literal and no format arguments [-Werror=format-security]
  318 |             mvprintw(height/2, (width/2)-(strlen(errstr)/2), errstr);
      |             ^~~~~~~~
cc1: some warnings being treated as errors
make: *** [<builtin>: ttyplot] Error 1

https://github.com/tenox7/ttyplot/blob/master/ttyplot.c#L318

Using the following will solve the problem:

            mvprintw(height/2, (width/2)-(strlen(errstr)/2), "%s", errstr);