search

tenox7 / wrp

Web Rendering Proxy: Use vintage, historical, legacy browsers on modern web
Apache License 2.0
1.08k stars 52 forks source link

Add CLI argument to override Browser executable Path #96

Open c-amie opened 2 years ago

c-amie commented 2 years ago

Hi,

Great little project! A small suggestion. I've done a bit of testing and if you copy the application executable for either MS Edge or Brave Browser into C:\Program Files\Google\Chrome\Application and rename the executable file for each to chrome.exe. WRP runs fine. This implies that the requirement for Chrome isn't explicit to Chrome/Chromium but is for any Chromium browser engine.

I was hoping you might consider implementing a change to project so that either there is a broader list of pre-defined paths to scan for the .exe (i.e. Add the Edge and Brave paths) or, preferably, add a environment variable / command line argument / ini file config line to specify the path to the browser.

This would change the requirement to install Chrome or Chromium into a requirement to install any Chromium based browser. It would also mean that it could work straight out of the box on every Windows install that ships with Edge; no other depenencies required. Equally, if the user doesn't want to use Google Chrome, then they don't have to.

e.g.

wrp-386-windows.exe -b "C:\Program Files\Microsoft\Edge\Application\msedge.exe" wrp-386-windows.exe -b "C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe"

-or-

set chromepath = C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe wrp-386-windows.exe

Here the executable uses the value of %chromepath% to locate the browser.

-or-

Add a wrp.ini file to the file set and make chromePath a configurable option in here.

tenox7 commented 2 years ago

Hi thank you! Yes thats a very good suggestion. This aspect is controlled by the chromedp library I'm using (https://github.com/chromedp/chromedp). I will take a look to see if the browser location can somehow be passed on to chromedp context.