tensor-compiler / taco

The Tensor Algebra Compiler (taco) computes sparse tensor expressions on CPUs and GPUs
http://tensor-compiler.org
Other
1.23k stars 186 forks source link

taco-tool: the benchmark utility of the taco tool no longer works #492

Open rohany opened 2 years ago

rohany commented 2 years ago

If you attempt to benchmark programs with the taco-tool, i.e. specifying formats, data and -time=5, the program fails with a generated code compilation error.

pinging @Infinoid because I think you were the last person to touch the code around this area, based on git blame.

stephenchouca commented 2 years ago

I believe this bug should actually be fixed in the eval_at_assign branch. Can you check if that's the case?

rohany commented 2 years ago

I see this error now:

[yadav2@lassen737:build]$ ./bin/taco "a(i) = B(i, j) * c(i)" -f=a:d -f=B:ds -f=c:d -g=c:d -time=5 -i=B:../../taco/petsc/test-mat.mtx
B file read: 0.846304 ms
B pack:      157.335 ms
B size: (5 x 5), 64 bytes
c size: (5), 44 bytes

Compile:  151.851 ms
terminate called after throwing an instance of 'taco::TacoException'
  what():  Error at /g/g15/yadav2/taco-master/src/tensor.cpp:881 in compileSource:
 Cannot compile with custom source if kernel already compiled
Aborted
[yadav2@lassen737:build]$

test-mat.mtx is just a small mtx file.

stephenchouca commented 2 years ago

Commit 823e8da works fine for me, so I'm not sure what's going on:

stephenchouca@DESKTOP-9ANRGV7:~/taco/build$ ./bin/taco "a(i) = B(i, j) * c(i)" -f=a:d -f=B:ds -f=c:d -g=c:d -time=5 -i=B:cage3/cage3.mtx
B file read: 0.2232 ms
B pack:      148.265 ms
B size: (5 x 5), 256 bytes
c size: (5), 44 bytes

Compile:  151.041 ms
Assemble: 0.2958 ms
Compute time (ms)
  mean:   0.13288
  stdev:  0.0234832
  median: 0.118
rohany commented 2 years ago

Ah I think I didn't rebuild properly. It works for me now. Let me see what I can pull in from the commit to fix the issue on my branch.