tensor-compiler / taco

The Tensor Algebra Compiler (taco) computes sparse tensor expressions on CPUs and GPUs
http://tensor-compiler.org
Other
1.25k stars 188 forks source link

qcd.mul1 fails on Apple M1 #528

Open certik opened 2 years ago

certik commented 2 years ago

I installed Taco on Apple M1 Max using:

mkdir build
cd build
cmake -DCMAKE_BUILD_TYPE=Release -DPYTHON=ON ..

And tested using ctest. All tests pass, except:

$ ctest -R qcd.mul1 -V
UpdateCTestConfiguration  from :/Users/ondrej/repos/taco/build/DartConfiguration.tcl
UpdateCTestConfiguration  from :/Users/ondrej/repos/taco/build/DartConfiguration.tcl
Test project /Users/ondrej/repos/taco/build
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 99
    Start 99: qcd.mul1

99: Test command: /Users/ondrej/repos/taco/build/bin/taco-test "--gtest_filter=qcd.mul1"
99: Test timeout computed to be: 10000000
99: Note: Google Test filter = qcd.mul1
99: [==========] Running 1 test from 1 test case.
99: [----------] Global test environment set-up.
99: [----------] 1 test from qcd
99: [ RUN      ] qcd.mul1
99: Value of: getScalarValue(tau)
99:   Actual: 0.41212798763234709
99: Expected: 0.41212798763234737
99: [  FAILED  ] qcd.mul1 (200 ms)
99: [----------] 1 test from qcd (200 ms total)
99: 
99: [----------] Global test environment tear-down
99: [==========] 1 test from 1 test case ran. (200 ms total)
99: [  PASSED  ] 0 tests.
99: [  FAILED  ] 1 test, listed below:
99: [  FAILED  ] qcd.mul1
99: 
99:  1 FAILED TEST
1/1 Test #99: qcd.mul1 .........................***Failed    0.36 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.37 sec

The following tests FAILED:
     99 - qcd.mul1 (Failed)
Errors while running CTest
Output from these tests are in: /Users/ondrej/repos/taco/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
rohany commented 2 years ago

I'm not sure anyone on the development team right now has an M1 mac to reproduce this issue. However, it looks like a small precision error that seems ignorable?

certik commented 2 years ago

Yes, it seems the test should be fixed to account for these small errors.