search

tensor4all / TensorCrossInterpolation.jl

https://tensor4all.github.io/TensorCrossInterpolation.jl/
MIT License
21 stars 1 forks source link

Implantation of strictlynested = false is something wrong #1

Closed shinaoka closed 6 months ago

shinaoka commented 6 months ago

The implementation may need to be corrected. The correct one is that before each half sweep, back up all I and J sets and add them to Pi tensors during the half sweep. https://github.com/tensor4all/TensorCrossInterpolation.jl/blob/main/src/tensorci2.jl#L787-L799

rittermarc commented 6 months ago

Agreed. That part of the code has to be inside the loop.