30 remove iset history and jset history from tensorci2

tensor4all / TensorCrossInterpolation.jl

https://tensor4all.github.io/TensorCrossInterpolation.jl/

MIT License

21 stars 1 forks source link

30 remove iset history and jset history from tensorci2 #31

Closed shinaoka closed 2 months ago

shinaoka commented 3 months ago

Remove history from TCI2.
Unified implementation for adding external global pivots and internal global pivots

rittermarc commented 3 months ago

I think this is good logic, and I didn't find any problems testing it. I would like to clean up some of the new documentation & error messages though, should I just change these myself?

shinaoka commented 3 months ago

As I wrote to you by e-mail, I have a different new idea. Let us first check the new one before merging this PR.

shinaoka commented 3 months ago

@rittermarc Let us merge this into the main branch. Do you want to still edit the branch yourself before the merge?

shinaoka commented 2 months ago

This approach is not the way to go, as we discussed on Zoom.