Instead of using window background color for menu bar unconditionally, check if menu bar has a background color, and then fall back to window color. This fixes the menu bar background for themes, which uses different background colors for menu bar and window, e.g. Blue-Submarine and Green-Submarine from the mate-themes package.
I remember trying and pick the menu_bar color directly, and it would result in rgba(0,0,0,0). That's way you are using if (background_color_ptr->alpha == 0.0).
👍
Instead of using window background color for menu bar unconditionally, check if menu bar has a background color, and then fall back to window color. This fixes the menu bar background for themes, which uses different background colors for menu bar and window, e.g. Blue-Submarine and Green-Submarine from the mate-themes package.