hunspell as optional dep

tensor5 / arch-atom

Repository of Atom and Electron binary packages for Arch Linux

48 stars 5 forks source link

hunspell as optional dep #45

Open rumpelsepp opened 7 years ago

rumpelsepp commented 7 years ago

When someone wants to use the spellchecking plugin, then hunspell-* must be installed. It makes sense for me to add those as optional deps.

tensor5 commented 7 years ago

It's a good idea! Right now Atom looks for dictionaries in /usr/lib/atom/node_modules/spellchecker/vendor/hunspell_dictionaries (code here). I could make a patch and make it point at /usr/share/hunspell which is where Arch installs hunspell-* dictionaries.

rumpelsepp commented 7 years ago

Really? I installed the packages from the arch repos, which place the dicts in /usr/share/myspell/dicts/de_DE.dic, /usr/share/hunspell/de_DE.dic. Atom seems to find them.

tensor5 commented 7 years ago

Well, then there is no need to patch. So the question is whether a package that has spellchecking features should have dictionaries among its optional dependencies. Seems like the arch-dev mailing list is the right place to raise this issue.