feat: support `shell("fish")`

[kemingy]

Description

fish is another modern shell that works out of the box. It would be good to support the following command in envd.

def build():
    base(os="ubuntu20.04")
    shell("fish")

---

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

[kemingy]

Requirements:

• apt install fish
• starship init fish
• fish config (conda init if it's required)

[kemingy]

Also, it will be good if can support fish shell autocomplete.

[Belyenochi]

If no one else, please assign it to me :-).

[kemingy]

/assign @Belyenochi

[gaocegege]

It may be not easy. Feel free to ask here if you encountered any problem!

Thanks for your contribution! :tada: :+1:

[Belyenochi]

@gaocegege @kemingy I'm trying to re-understand the problem, from what I've tried, if I run something like the following,

// build.envd
def build():
    base(os="ubuntu20.04", language="python3")
    shell("fish")
    config.jupyter()

envd will install fish in the build ubuntu image, and I understand what we need to do is modify /pkg/lang/ir /custom.go or similar file to support installed in the default image and initializes fish related configuration (including autocompletion plugins?)

[kemingy]

envd will install fish in the build ubuntu image, and I understand what we need to do is modify /pkg/lang/ir /custom.go or similar file to support installed in the default image and initializes fish related configuration (including autocompletion plugins?)

• Yes, we will use shell("fish")
• Need to modify several files, I think you can search "zsh" in the codebase as a reference (no need to install oh-my-fish or something similar)
• envd fish autocomplete should be placed in pkg/autocomplete/fish.go

[Belyenochi]

envd will install fish in the build ubuntu image, and I understand what we need to do is modify /pkg/lang/ir /custom.go or similar file to support installed in the default image and initializes fish related configuration (including autocompletion plugins?)

• Yes, we will use shell("fish")
• Need to modify several files, I think you can search "zsh" in the codebase as a reference (no need to install oh-my-fish or something similar)
• envd fish autocomplete should be placed in pkg/autocomplete/fish.go

Thanks for your patience :-).

[kemingy]

Hi @Belyenochi, it has been a while. May I know if you're still working on this issue?

Feel free to ask for help.

[Belyenochi]

Hi @Belyenochi, it has been a while. May I know if you're still working on this issue?

Feel free to ask for help.

Hi @kemingy , I'm working on it, maybe a PR in two weeks

[kemingy]

Hi @Belyenochi, it has been a while. May I know if you're still working on this issue? Feel free to ask for help.

Hi @kemingy , I'm working on it, maybe a PR in two weeks

Thanks

[kemingy]

Hi @Belyenochi any update?

[Belyenochi]

@kemingy Sorry for not updating yet, if the priority is not high, I will continue to take time to complete it.

[kemingy]

Hi @Belyenochi any progress?