Open aseaday opened 2 years ago
@kemingy @VoVAllen @zwpaper WDYT?
It seems great to me!
I have some questions, maybe we can discuss or explain them in docs
RuntimeCommands
is not saved, if this feature goes, maybe RuntimeCommands
should also be saved?Thanks for the proposal! Sounds good to me. Also do you have any specific scenarios for this? So that we can understand the pro/cons when implement it.
It seems great to me!
I have some questions, maybe we can discuss or explain them in docs
- https://github.com/tensorchord/envd/pull/815/files proposed
RuntimeCommands
is not saved, if this feature goes, maybeRuntimeCommands
should also be saved?- should we add an option to disable(or enable) this inherit?
- when inheriting, how would we overwrite if new components(RuntimeCommands, Envs, etc.) written in the new build.envd by users?
runtime.command
, I deleted it now.base
function to turn it on/off.runtime.xxx
functions had no overwrite feature. We can treat base
inheritance as a function contains some runtime
and how to overwrite is decided by the runtime.xxx
's overwrite deisgn.A specific scenarios is as the follows: User Alice is a team member who build a base image for the others especially new commers. He hope the containers could do some followings things automatically:
runtime.command("dvc sync")
runtime.expose
and runtime.daemon
Alice don't want the others users include
which means it need to rebuild again. Alice want the base
could inherit the runtime feature from parent image directly.
@VoVAllen
I see what you mean. And I realized this can also be a way if users want explicit dependency control. Currently, apt install
and pip package install
happen in parallel, all on base images. If user want explicit dependency such as python depends on apt packages, your proposal can be a solution
Description
We support the custome image now:
And if the user's envd manifest has a custom base image built from envd such as:
And the base image's envd files may had some runtime configurations as followings:
We should support inheritance so that the new container could has these runtime functions automatically. It is related to https://github.com/tensorchord/envd/pull/815 and if this feature prposal was approved by community. I will add this function to #815
Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.