search

tensorchord / pgvecto.rs

Scalable, Low-latency and Hybrid-enabled Vector Search in Postgres. Revolutionize Vector Search, not Database.
https://docs.pgvecto.rs/getting-started/overview.html
Apache License 2.0
1.53k stars 60 forks source link

Implement aggregate functions for sparse vector. #476

Closed my-vegetable-has-exploded closed 3 weeks ago

my-vegetable-has-exploded commented 1 month ago

refs #475

Purpose of this pr is almost same with #463, but mainly for sparse vector.

VoVAllen commented 1 month ago

@usamoi PTAL

VoVAllen commented 1 month ago

Is this ready to merge?

my-vegetable-has-exploded commented 1 month ago

Is this ready to merge?

not yet. I am rewriting the state amd related function.

VoVAllen commented 1 month ago

@usamoi PTAL

VoVAllen commented 1 month ago

Ready to merge?

my-vegetable-has-exploded commented 1 month ago

ptal @usamoi

VoVAllen commented 1 month ago

Since it's hard to review, can @my-vegetable-has-exploded add more randomized tests and run multiple times locally to ensure the correctness?

VoVAllen commented 1 month ago

Both end2end and unit test

my-vegetable-has-exploded commented 1 month ago

Since it's hard to review, can @my-vegetable-has-exploded add more randomized tests and run multiple times locally to ensure the correctness?

Okay, I'll also look into how to make the code more readable.

my-vegetable-has-exploded commented 3 weeks ago

ptal @usamoi