MajesticKhan commented 5 years ago

The update allows Adanet to run on Windows OS without encountering issues caused by removing the "temp_model_dir".

_prepare_next_iteration() will create a "temp_model_dir" that will contain sub directories. Each sub directory will contain a temporary model. Once the model is finished creating the graphs, the parent directory will be deleted.

If the OS is Windows, the try/except will handle errors that are related to deleting the parent directory.

Sources for the error handling:

codecov-io commented 5 years ago

Codecov Report

Merging #106 into master will decrease coverage by 0.01%. The diff coverage is 70%.

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   90.68%   90.66%   -0.02%     
==========================================
  Files          31       31              
  Lines        2704     2709       +5     
  Branches      431      431              
==========================================
+ Hits         2452     2456       +4     
- Misses        175      176       +1     
  Partials       77       77

Impacted Files	Coverage Δ
adanet/core/estimator.py	`91.94% <70%> (-0.11%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ebbb7ee...ce21980. Read the comment docs.

cweill commented 5 years ago

Thanks! This looks good to me. I'll merge it on our end.

cweill commented 5 years ago

Merged.

tensorflow / adanet

Try/Catch solution for running Adanet on Windows OS #106

Codecov Report