tensorflow / adanet

Fast and flexible AutoML with learning guarantees.
https://adanet.readthedocs.io
Apache License 2.0
3.47k stars 527 forks source link

Fixing typo in example and changing default eval throttle_secs since … #95

Closed zjost closed 5 years ago

zjost commented 5 years ago

…this causes rapid re-evaluation in TF 1.9

Resolving #61 . Just changing throttle_secs from 1 to 30 in tf.estimator.EvalSpec.

review-notebook-app[bot] commented 5 years ago

Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/adanet/pull/95

Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

zjost commented 5 years ago

I signed it!

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

codecov-io commented 5 years ago

Codecov Report

Merging #95 into master will decrease coverage by 2.7%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   91.61%   88.91%   -2.71%     
==========================================
  Files          30       30              
  Lines        2589     2589              
  Branches      441      441              
==========================================
- Hits         2372     2302      -70     
- Misses        147      213      +66     
- Partials       70       74       +4
Impacted Files Coverage Δ
adanet/core/estimator_distributed_test_runner.py 32.32% <0%> (-56.57%) :arrow_down:
adanet/core/tpu_estimator.py 37.96% <0%> (-2.78%) :arrow_down:
adanet/core/estimator.py 90.26% <0%> (-1.69%) :arrow_down:
adanet/core/iteration.py 90.49% <0%> (-0.71%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05b0185...fb4fc7b. Read the comment docs.

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

zjost commented 5 years ago

Updated author info on commit to pass CLA check.

cweill commented 5 years ago

@zjost: Thanks, I'll have a look.