tensorflow / addons

Useful extra functionality for TensorFlow 2.x maintained by SIG-addons
Apache License 2.0
1.69k stars 611 forks source link

Fix Test Suite #2816

Closed seanpmorgan closed 1 year ago

seanpmorgan commented 1 year ago

Description

Test suite has several uses of np.bool and np.int which are no longer in the most recent version of numpy.

seanpmorgan commented 1 year ago

@MarkDaoust when time allows can you take a look at the failure for doc build: ImportError: cannot import name 'builder' from 'google.protobuf.internal' (/usr/local/lib/python3.9/site-packages/google/protobuf/internal/__init__.py)

Seems like protobuf changes recently.

Here is how we run the tests: https://github.com/tensorflow/addons/blob/master/tools/docker/sanity_check.Dockerfile#L81-L98 https://github.com/tensorflow/addons/blob/master/tools/install_deps/doc_requirements.txt

bhack commented 1 year ago

@seanpmorgan https://github.com/protocolbuffers/protobuf/issues/9778#issuecomment-1097524415

MarkDaoust commented 1 year ago

Yeah, sorry about that.

TF 2.12 is switching to the new version of protobuf.

https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/pip_package/setup.py#L100

I updated the docs tools a few weeks ago.

You're going to need to follow for the 2.12 compatible release.

But if you do want this to just pass you could point the requirement to the commit just before the update: git+https://github.com/tensorflow/docs@c1510dc5ad73aa829249822798e6263360b0f62a