search

tensorflow / addons

Useful extra functionality for TensorFlow 2.x maintained by SIG-addons
Apache License 2.0
1.69k stars 610 forks source link

Build against TF 2.15 #2857

Closed seanpmorgan closed 9 months ago

seanpmorgan commented 9 months ago

Looks like a header is missing for Windows TF2.15: https://github.com/tensorflow/tensorflow/issues/61830

@bhack @angerson I think intel builds the windows whls now?

seanpmorgan commented 9 months ago

I lean toward dropping Windows support until upstream is fixed. Alternative is to build against TF2.14 for windows with the risk of segfaults in windows custom ops due to incompatible abi

bhack commented 9 months ago

Yes I agree to remove it at least if something will not change with this ticket:

https://github.com/tensorflow/tensorflow/issues/59918

I think that the Intel team can release a window version of Addons compatible with their window TF artifacts if requested.

bhack commented 9 months ago

I think we could add a string in the Readme.

seanpmorgan commented 9 months ago

I think we could add a string in the Readme.

Added. Hoping that we can just add it back with a patch release but the issue is a few months old now without any sign of fix coming

bhack commented 9 months ago

Added. Hoping that we can just add it back with a patch release but the issue is a few months old now without any sign of fix coming

Yes we could just subscribe to the upstream ticket.