tensorflow / build

Build-related tools for TensorFlow
Apache License 2.0
270 stars 111 forks source link

Remove global setting of LD_LIBRARY_PATH #104

Closed sampathweb closed 2 years ago

sampathweb commented 2 years ago

This change failed to capture the downstream effects of tensorflow installs on CPU that doesn't have the Cuda libraries.

The smoke test failed to capture the effect correctly when importing tensorflow on systems that didn't have this global variable set.

>>> import tensorflow as tf

Reverts PR #100 and #102

github-actions[bot] commented 2 years ago

I pushed these containers:

Re-apply the build and push to gcr.io for staging label to rebuild and push again. This comment will only be posted once.

sampathweb commented 2 years ago

Tested by running nightly successfully using the SIG Docker Build: https://fusion2.corp.google.com/invocations/ce8d3fb5-7ba9-44c7-909e-2f51c2b4aa90/log