search

tensorflow / build

Build-related tools for TensorFlow
Apache License 2.0
278 stars 114 forks source link

Docker exec ctrl+c suggestion #49

Closed bhack closed 2 years ago

bhack commented 2 years ago

https://github.com/tensorflow/build/blob/42a990a6859d6acbb2e9667049d4105ce332965a/tf_sig_build_dockerfiles/README.md?plain=1#L67-L69

  • If you interrupt a docker exec command with ctrl-c, you will get your shell back but the command will continue to run. You cannot reattach to it. If you have any suggestions for handling this, let us know.

We could run a tmux or byobu session in the container so it could be easy to attach again to the session without having a detached process in case of crtl+c

angerson commented 2 years ago

We can revisit this once we're focusing contributor QoL for the containers. Right now I'm only concerned with CI, where this is not a problem.