search

tensorflow / build

Build-related tools for TensorFlow
Apache License 2.0
278 stars 114 forks source link

Make build environment manylinux2014 compatible #57

Closed nitins17 closed 2 years ago

nitins17 commented 2 years ago

Modifies the build environment to be manylinux2014 compatible

Changes include:

github-actions[bot] commented 2 years ago

I pushed these containers:

Re-apply the build and push to gcr.io for staging label to rebuild and push again. This comment will only be posted once.

github-actions[bot] commented 2 years ago

I pushed these containers:

Re-apply the build and push to gcr.io for staging label to rebuild and push again. This comment will only be posted once.

guizili0 commented 2 years ago

Hi did this PR has relationships with -cxxopt="-D_GLIBCXX_USE_CXX11_ABI=1" and do you plan enable it in TensorFlow release binary? Thanks!

bhack commented 2 years ago

We could also check https://discuss.python.org/t/how-to-set-glibcxx-use-cxx11-abi-for-manylinux2014-and-manylinux2010-wheels/10551

nitins17 commented 2 years ago

Hi did this PR has relationships with -cxxopt="-D_GLIBCXX_USE_CXX11_ABI=1" and do you plan enable it in TensorFlow release binary? Thanks!

Hi,

This PR is for updating the TensorFlow's Linux wheel to be manylinux2014 compliant. As far as I can tell, D_GLIBCXX_USE_CXX11_ABI would still be equal to 0 because we set --with-default-libstdcxx-abi="gcc4-compatible"; see with-default-libstdcxx-abi in https://gcc.gnu.org/onlinedocs/libstdc++/manual/configure.html

bhack commented 2 years ago

@nitins17 Do you know what was the reason for including --with-default-libstdcxx-abi="gcc4-compatible" flag?

nitins17 commented 2 years ago

@nitins17 Do you know what was the reason for including --with-default-libstdcxx-abi="gcc4-compatible" flag?

I'm not sure. @mihaimaruseac wdyt?

bhack commented 2 years ago

@nitins17 Do you know what was the reason for including --with-default-libstdcxx-abi="gcc4-compatible" flag?

I'm not sure. @mihaimaruseac wdyt?

What was the conclusion about this point in the last SIG build meeting?

nitins17 commented 2 years ago

Hi did this PR has relationships with -cxxopt="-D_GLIBCXX_USE_CXX11_ABI=1" and do you plan enable it in TensorFlow release binary? Thanks!

Hi,

This PR is for updating the TensorFlow's Linux wheel to be manylinux2014 compliant. As far as I can tell, D_GLIBCXX_USE_CXX11_ABI would still be equal to 0 because we set --with-default-libstdcxx-abi="gcc4-compatible"; see with-default-libstdcxx-abi in https://gcc.gnu.org/onlinedocs/libstdc++/manual/configure.html

On this, after the discussion in the March 2022 edition of the TF Sig Build meeting, the manylinux2014 upgrade will also include the change to new libstdcxx ABI. For more information on this and the manylinux2014 rollout, please take a look at this community thread.

Thanks!

guizili0 commented 2 years ago

Hi did this PR has relationships with -cxxopt="-D_GLIBCXX_USE_CXX11_ABI=1" and do you plan enable it in TensorFlow release binary? Thanks!

Hi, This PR is for updating the TensorFlow's Linux wheel to be manylinux2014 compliant. As far as I can tell, D_GLIBCXX_USE_CXX11_ABI would still be equal to 0 because we set --with-default-libstdcxx-abi="gcc4-compatible"; see with-default-libstdcxx-abi in https://gcc.gnu.org/onlinedocs/libstdc++/manual/configure.html

On this, after the discussion in the March 2022 edition of the TF Sig Build meeting, the manylinux2014 upgrade will also include the change to new libstdcxx ABI. For more information on this and the manylinux2014 rollout, please take a look at this community thread.

Thanks!

That's great, thanks for this!!

angerson commented 2 years ago

Note that the images, when not cached, take quite a long time to build both dt7 and dt9 -- eventually we'll remove dt7, tentatively "after the TF 2.9 release."