tensorflow / cloud

The TensorFlow Cloud repository provides APIs that will allow to easily go from debugging and training your Keras and TensorFlow code in a local environment to distributed training in the cloud.
https://github.com/tensorflow/cloud
Apache License 2.0
377 stars 91 forks source link

Performance issues in /src/python/tensorflow_cloud/core (by P3) #371

Open DLPerf opened 3 years ago

DLPerf commented 3 years ago

Hello! I've found a performance issue in /tests/testdata/keras_tuner_cifar_example.py: batch() should be called before map(), which could make your program more efficient. Here is the tensorflow document to support it.

Detailed description is listed below:

Besides, you need to check the function called in map()(e.g., scale called in .map(scale)) whether to be affected or not to make the changed code work properly. For example, if scale needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z).

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

DLPerf commented 3 years ago

Hello, I'm looking forward to your reply~

sharmadhiraj86 commented 2 years ago

I would like to contribute in solving this issue. Can you please assign this issue to me? @DLPerf @lamberta @mihaimaruseac @jaeyounkim @martinwicke

mihaimaruseac commented 2 years ago

We don't generally assign issue to contributors. Instead, please send a PR when ready.

sahil270803 commented 1 month ago

I resolved the performance issue by changing the order of operations in the dataset pipeline, calling .batch(BATCH_SIZE) before .map(scale). This modification improves efficiency by batching the data before applying the map function, reducing the number of individual function calls.