search

tensorflow / community

Stores documents used by the TensorFlow developer community
Apache License 2.0
1.26k stars 576 forks source link

RFC: SavedModel Fingerprinting #415

Closed monicadsong closed 2 years ago

monicadsong commented 2 years ago

This RFC will be open for comment until June 23, 2022.

Status Approved
RFC # 415
Author(s) Monica Song (monicadsong@google.com)
Sponsor Cesar Crusius (ccrusius@google.com)
Updated 2022-07-13

Objective

Following the convention of other types of electronic files and artifacts, the SavedModel format would benefit from having a fingerprint that uniquely identify the program it serializes. This fingerprint will better enable users to track their SavedModels in ML pipelines and other infrastructure using native metadata.

ematejska commented 2 years ago

Waiting for approval from Cesar as the sponsor

bhack commented 2 years ago

@ematejska Still in proposed phase but already landing in master:

https://github.com/tensorflow/tensorflow/commit/c075b1551708f283117807c65b3cd61701de95e4

monicadsong commented 2 years ago

@ematejska Still in proposed phase but already landing in master:

tensorflow/tensorflow@c075b15

Thank you pointing that out. Sorry, the commit description should have been clearer and specify that there are no functional changes introduced in this commit since all development for SavedModel fingerprinting is gated behind a flag added in https://github.com/tensorflow/tensorflow/commit/cdbc8d7091e1ab1fdad0e25b02a08ccb2c0e878b.

I am planning to turn on SM fingerprinting in the TF library once all doc approvals have been received and the feature has been thoroughly tested!

bhack commented 2 years ago

Ok, but on the other side we need to understand if we want community RFC related PR merged before RFC approval.

Probably not, so if we can it is better to be on the same page.

ematejska commented 2 years ago

This is now approved.