Open ChanchalKumarMaji opened 4 years ago
@ChanchalKumarMaji Yes I also observed it many files have wrong pylint. So can we correct it and sending PR's ?
Thank you for reporting. Please don't hesitate to fix those if you have time.
Okay I think we have to send multiple PR's for this, So I am sending PR for tensorflow_datasets/image
soon.
Okay I think we have to send multiple PR's for this, So I am sending PR for
tensorflow_datasets/image
soon.
Sure, Thanks! :smiley: .
Thanks for reporting this @ChanchalKumarMaji, I'll start working on tensorflow_datasets/audio
.
I've completed tensorflow_datasets/audio
in the above PR. Plz review it.
Meanwhile, I'll start working on tensorflow_datasets/object_detection
.
Thanks.
@Conchylicultor please have a look, and let me know if it requires any correction.
Short description Many
pylint
errors exists in TFDS. Runningpylint
not generating 10.0/10 rating.For example running
./oss_scripts/lint.sh tensorflow_datasets/image
gives -click here
``` Using config file /tmp/pylintrc ************* Module tensorflow_datasets.image.so2sat C: 93, 2: Missing method docstring (missing-docstring) C:150, 6: Consider using enumerate instead of iterating with range and len (consider-using-enumerate) ************* Module tensorflow_datasets.image.clevr C:100, 2: Missing method docstring (missing-docstring) ************* Module tensorflow_datasets.image.places365_small_test C: 1, 0: Missing module docstring (missing-docstring) ************* Module tensorflow_datasets.image.patch_camelyon C: 69, 2: Missing method docstring (missing-docstring) ************* Module tensorflow_datasets.image.eurosat C:102, 2: Missing method docstring (missing-docstring) ************* Module tensorflow_datasets.image.caltech_birds C: 84, 2: Missing method docstring (missing-docstring) ************* Module tensorflow_datasets.image.oxford_flowers102_test C: 44, 0: Trailing newlines (trailing-newlines) ************* Module tensorflow_datasets.image.patch_camelyon_test C: 27, 0: Missing class docstring (missing-docstring) ************* Module tensorflow_datasets.image.visual_domain_decathlon C:111, 2: Missing method docstring (missing-docstring) ************* Module tensorflow_datasets.image.sun C:225, 2: Missing method docstring (missing-docstring) R:242, 4: Unnecessary "else" after "return" (no-else-return) C:276, 2: Missing method docstring (missing-docstring) C:305, 2: Missing method docstring (missing-docstring) ************* Module tensorflow_datasets.image.stanford_online_products_test C: 1, 0: Missing module docstring (missing-docstring) ************* Module tensorflow_datasets.image.duke_ultrasound C:116, 2: Missing method docstring (missing-docstring) C:143, 2: Missing method docstring (missing-docstring) ************* Module tensorflow_datasets.image.imagenet2012_corrupted_test C: 28, 0: Missing class docstring (missing-docstring) ************* Module tensorflow_datasets.image.cars196_test C: 1, 0: Missing module docstring (missing-docstring) ************* Module tensorflow_datasets.image.caltech_test C: 26, 0: Missing class docstring (missing-docstring) C: 35, 2: Method name "setUp" doesn't conform to u'^(?:(?P
Expected Behaviour Remove all
pylint
errors. Sometimes it requires -# pylint: disable=some-error-message
.CC : @Conchylicultor