search

tensorflow / decision-forests

A collection of state-of-the-art algorithms for the training, serving and interpretation of Decision Forest models in Keras.
Apache License 2.0
658 stars 108 forks source link

tf_keras doesn't run in colab, revert back to tf.keras for working demo #206

Closed hchiam closed 8 months ago

hchiam commented 8 months ago

i copied the latest code as of today from the decision forests tutorial and i noticed tf_keras doesn't work in colab.

to get it to work, i had to undo the changes made to documentation/tf_df_in_tf_js.md (see part of b9a4cf1) back to using tf.keras for the second python code snippet, in order for it to successfully work in colab to download the zip file. i'm working on making sure the final js step works in my own local demo in order to fix https://github.com/tensorflow/decision-forests/issues/205 in a separate PR

rstz commented 8 months ago

Hi, thank you for this PR. Since tf_keras will be necessary once TensorFlow 2.16 comes out (which is probably quite soon), I created a change to forward-fix this issue instead of reverting. Will close this PR once the fix has landed