tensorflow / decision-forests

A collection of state-of-the-art algorithms for the training, serving and interpretation of Decision Forest models in Keras.
Apache License 2.0
663 stars 110 forks source link

get tf_df_in_tf_js.md colab code to export all 3 files (fix #205) #207

Closed hchiam closed 9 months ago

hchiam commented 10 months ago

fix #205

i made an even more recent demo today of it requiring these changes to work --> in that folder, you can find two .ipynb files for reference:

rstz commented 10 months ago

I believe this is no longer required after 14b58329b8115a63246903d51de32cf06b467b30 landed, please confirm

hchiam commented 10 months ago

I believe this is no longer required after 14b5832 landed, please confirm

unfortunately the issue still seems to exist - when i unzip the file, it's still missing the assets.zip file:

still_not_getting_all_3_files

https://colab.research.google.com/drive/18Rqmg0sa9KNphPh3F0RmNve2wCZBDQUI?usp=sharing

so just running the code as-is written in https://github.com/tensorflow/decision-forests/blob/14b58329b8115a63246903d51de32cf06b467b30/documentation/tf_df_in_tf_js.md#running-tensorflow-decision-forests-models-with-tensorflowjs won't get all files needed for my local js demo to run

unless i did something wrong in my colab

rstz commented 10 months ago

You're absolutely right, sorry! Thank you very much for the fix!