search

tensorflow / decision-forests

A collection of state-of-the-art algorithms for the training, serving and interpretation of Decision Forest models in Keras.
Apache License 2.0
663 stars 110 forks source link

Performance issues in tensorflow_decision_forests/keras/keras_test.py(P2) #55

Closed DLPerf closed 3 years ago

DLPerf commented 3 years ago

Hello,I found a performance issue in the definition of _synthetic_train_and_test , tensorflow_decision_forests/keras/keras_test.py, compression_type="GZIP").map(parse) was called without num_parallel_calls. I think it will increase the efficiency of your program if you add this.

The same issues also exist in test_path, compression_type="GZIP").map(parse).batch(50).map(preprocess)

Here is the documemtation of tensorflow to support this thing.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

SaultanBeagama commented 3 years ago

ليه

achoum commented 3 years ago

Hi,

Could you please elaborate on why this is performance issue, and what are the expected gains? Keep in mind that tests are running in parallel.

It seems you proposed the exact same change to many tensorflow github projects. I suspect you developed some tools to assist you. Independently of this particular issue, it would be interesting to learn more about it :)