tensorflow / ecosystem

Integration of TensorFlow with other open-source frameworks
Apache License 2.0
1.37k stars 391 forks source link

Shade tensorflow-hadoop jar #121

Closed pgandhi999 closed 5 years ago

pgandhi999 commented 5 years ago

We have seen that certain implementations of tensorflow provide their own tensorflow-hadoop dependency which comes in conflict with spark-tensorflow-connector jar dependencies. Thus, shading tensorflow-hadoop jar would be a better alternative here.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Googlers can find more info about SignCLA and this PR by following this link.

pgandhi999 commented 5 years ago

I signed it!

jhseu commented 5 years ago

Can you follow the CLA troubleshooting? Perhaps your e-mail is not on the git commit?

To update, you can either force push or make a new pull request.

pgandhi999 commented 5 years ago

Will try that, thank you @jhseu .