search

tensorflow / ecosystem

Integration of TensorFlow with other open-source frameworks
Apache License 2.0
1.37k stars 392 forks source link

ArrayType(StringType) is not supported when writing to SequenceExample #134

Open zhangxuhong opened 5 years ago

zhangxuhong commented 5 years ago

https://github.com/tensorflow/ecosystem/blob/12d65f29b29a1b5bc975d9c11745b6e67818a6ae/spark/spark-tensorflow-connector/src/main/scala/org/tensorflow/spark/datasources/tfrecords/serde/DefaultTfRecordRowEncoder.scala#L96

This line of code indicates that ArrayType(StringType, _) will be encoded to FeatureList, however, method encodeFeatureList does not handle this case, and will throw exception. https://github.com/tensorflow/ecosystem/blob/12d65f29b29a1b5bc975d9c11745b6e67818a6ae/spark/spark-tensorflow-connector/src/main/scala/org/tensorflow/spark/datasources/tfrecords/serde/DefaultTfRecordRowEncoder.scala#L194

Is this on purpose or a bug?

bamine commented 4 years ago

Hello, any news regarding this ?

nicholas-leonard commented 4 years ago

I have same issue. The documentation is also lying about this because it says that ArrayType(SringType) is supported.