tensorflow / ecosystem

Integration of TensorFlow with other open-source frameworks
Apache License 2.0
1.37k stars 392 forks source link

support ArrayType(StringType, _) for SequenceExample #135

Open zhangxuhong opened 5 years ago

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

zhangxuhong commented 5 years ago

i signed

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jhseu commented 5 years ago

@skavulya Would you mind taking a look if you have time?

@zhangxuhong Mind adding a test?

zhangxuhong commented 5 years ago

@jhseu Thanks for taking a look at it. If this issue can be confirmed, i will add the corresponding tests.

skavulya commented 5 years ago

@zhangxuhong Thanks for the contribution. I'll take a look at it this evening to confirm the issue.

skavulya commented 4 years ago

@zhangxuhong Yes, this is an issue. Please add the unit tests. Thanks.