Open zhangxuhong opened 5 years ago
i signed
@skavulya Would you mind taking a look if you have time?
@zhangxuhong Mind adding a test?
@jhseu Thanks for taking a look at it. If this issue can be confirmed, i will add the corresponding tests.
@zhangxuhong Thanks for the contribution. I'll take a look at it this evening to confirm the issue.
@zhangxuhong Yes, this is an issue. Please add the unit tests. Thanks.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g.
I signed it!
) and we'll verify it.What to do if you already signed the CLA
Individual signers
Corporate signers
ℹ️ Googlers: Go here for more info.