tensorflow / ecosystem

Integration of TensorFlow with other open-source frameworks
Apache License 2.0
1.37k stars 391 forks source link

Support scala 2.12.10 and spark 2.4.4 #155

Closed vikatskhay closed 4 years ago

vikatskhay commented 4 years ago

Hello.

Related to https://github.com/tensorflow/ecosystem/pull/141#issuecomment-618852587

Not sure whether it'd be better to support multiple scala versions, perhaps introducing multiple profiles could be a good idea. As I understood from the comments https://github.com/tensorflow/ecosystem/pull/141 scala 2.11 could be left behind. Please let me know if I understood it incorrectly.

Tested with:

mvn clean install
googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

vikatskhay commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jhseu commented 4 years ago

@skavulya Mind taking a look?

groodt commented 4 years ago

I would really like a Scala 2.12 version to be published as well.

skavulya commented 4 years ago

@vikatskhay Thanks for the contribution. It looks good. @jhseu The PR is ready for merge.

vikatskhay commented 4 years ago

Thanks heaps for reviewing this PR. What should be my next steps to get it merged?

vikatskhay commented 4 years ago

Quick question: when could the new version be released including this change?

groodt commented 4 years ago

@jhseu @skavulya Does there need to be a new release to maven central now that this has been merged?

skavulya commented 4 years ago

maven central gets updated whenever a new TensorFlow version is released

groodt commented 4 years ago

maven central gets updated whenever a new TensorFlow version is released

Hmmm... is there a technical reason for this? It doesn't seem to be the case though, since there have been numerous TensorFlow releases since Aug 2018, but Maven central is showing that the last time this connector was released was in Aug 2018.

https://mvnrepository.com/artifact/org.tensorflow/spark-connector_2.11/1.10.0

skavulya commented 4 years ago

The connector is https://mvnrepository.com/artifact/org.tensorflow/spark-tensorflow-connector

There is no update since TensorFlow 2.0

@jhseu What would we need to do to update the release scripts?

NitinAgg commented 4 years ago

It seems this did not get updated with TF 2.2.

vikatskhay commented 4 years ago

Would be so great to get this out on maven central.