tensorflow / graphics

TensorFlow Graphics: Differentiable Graphics Layers for TensorFlow
Apache License 2.0
2.75k stars 361 forks source link

layer names #314

Open jackd opened 4 years ago

jackd commented 4 years ago

Style request: can layer names conform to tensorflow conventions? Specifically:

Happy to put in a PR with these changes (non-breaking with deprecated warnings on existing functions) if it's a desired direction.

I'd also love the layer submodule renamed layers, but that's probably a bit much to ask at this point (though if that's desired by others I can do this as well).

julienvalentin commented 4 years ago

Hi @jackd !

Makes sense! Let's maybe start with one of these layers to see what the suggested change implies?

Best.

taiya commented 4 years ago

+1 to both

I think via some init.py magic you could get layer → layers (agreed it is better) change to be non-breaking. TF does a fair bit of init magic in this sense too.