search

tensorflow / graphics

TensorFlow Graphics: Differentiable Graphics Layers for TensorFlow
Apache License 2.0
2.75k stars 361 forks source link

Feature request: NURBS support #315

Open mpmisko opened 4 years ago

mpmisko commented 4 years ago

The TF graphics library currently only supports B-Spline interpolation for uniform b-splines. Are there any plans to extend this to Non-Uniform Rational B-Splines (NURBS)? This would essentially mean giving users the option to provide a knot vector together with the control points. In the library, this would involve implementing De Boor's algorithm together with the gradients (a useful resource for b-spline gradients: http://www.stem2.org/je/bspline.pdf).

julienvalentin commented 4 years ago

Hi @mpmisko

Thanks for reaching out! Would that be something you would be interested to implement and contribute to TensorFlow Graphics? :)

Best.

mpmisko commented 4 years ago

There is an easy way to add support for NURBS weighted interpolation following this approach: https://pages.mtu.edu/~shene/COURSES/cs3621/NOTES/spline/NURBS/NURBS-def.html. I am more than happy to implement this if you think it is a good idea. :)

julienvalentin commented 4 years ago

That would be awesome!

yogeshhk commented 3 years ago

@mpmisko wish to know if you have started on this topic? If ok, I can join you and share/test the work. [cc: @julienvalentin]