search

tensorflow / graphics

TensorFlow Graphics: Differentiable Graphics Layers for TensorFlow
Apache License 2.0
2.75k stars 366 forks source link

Remove OpenEXR from requirements and warning #421

Open jonas-eschle opened 4 years ago

jonas-eschle commented 4 years ago

The docs and code say that OpenEXR is an optional dependency (https://github.com/tensorflow/graphics/blob/6b905c68e802b73c04857c21cca2e026cc37c900/tensorflow_graphics/util/data_formats/__init__.py#L25 or here but is seemingly is not. This means I cannot install the TFG package, since the OpenEXR does not get installed properly. Furthermore, the warning is rather annoying, as we would like to use some simple functionality from the package (bsplines) in a completely different context.

I would propose to a) remove OpenEXR from the dependency list and make it optional (as documented in docs and code) b) remove the warning and instead make OpenEXR a local import inside the function. If the function is called and it cannot be imported, it fails saying that it has to install OpenEXR first.

What do you think? Glad also to make this changes and contribute

atyshka commented 4 years ago

+1 on this, having to build an unwanted dependency from source is a burden

jonas-eschle commented 4 years ago

Is there any news on this?