tensorflow / graphics

TensorFlow Graphics: Differentiable Graphics Layers for TensorFlow
Apache License 2.0
2.75k stars 366 forks source link

Source install instructions outdated #580

Open firatozdemir opened 3 years ago

firatozdemir commented 3 years ago

Current latest stable release (v.1.0.0) is too outdated and has bugs which are fixed in the master branch.

I'm attempting to install from source, but the instructions are possibly outdated. I tried:

python setup.py sdist bdist_wheel --universal
pip install --upgrade dist/*.whl

which did not give any errors, and I can import library and get tfg.__version__='2021.6.7', however most modules are missing. For example, tfg.geometry returns

AttributeError: module 'tensorflow_graphics' has no attribute 'geometry'

Can you update instructions / point towards what's an obvious step I'm missing?

HotThoughts commented 2 years ago

I got the same error when trying to use the geometry module.

Example:

import tensorflow_graphics as tfg

tfg.geometry.transformation.rotation_matrix_3d.from_quaternion(
   quaternion
)

BUT, if I import geometry directly, e.g.,

import tensorflow_graphics.geometry.transformation as tfg

tfgt.rotation_matrix_3d.from_quaternion(
    quaternion
)

No error. Gives me the rotation matrix.

<tf.Tensor: shape=(1, 3, 3), dtype=float32, numpy=
array([[[-0.8486657 ,  0.52784616, -0.03383656],
        [ 0.52141696,  0.8241547 , -0.22111858],
        [-0.08883003, -0.20529874, -0.9746597 ]]], dtype=float32)>
NicolayP commented 1 year ago

Hi, Any update on why this happens when tensorflow_graphics is installed from source? I had the same error as @firatozdemir but manage to solve it as @HotThoughts suggested. Any idea why?