tensorflow / haskell

Haskell bindings for TensorFlow
https://tensorflow.github.io/haskell/haddock/
Apache License 2.0
1.58k stars 196 forks source link

Bump version constraints for proto-lens-* #247

Closed yorickvP closed 5 years ago

yorickvP commented 5 years ago

I confirmed that it still builds with 0.5.

yorickvP commented 5 years ago

It would be great if there was a hackage release after merging this.

blackgnezdo commented 5 years ago

It would be great if there was a hackage release after merging this.

We discussed this in #66, We don't know how to build this complicated library with cabal. If we were to publish as is we would get complaints about cabal not working.

Would it suffice if I put a tarball up on github?

blackgnezdo commented 5 years ago

It would be great if there was a hackage release after merging this.

We discussed this in #66, We don't know how to build this complicated library with cabal. If we were to publish as is we would get complaints about cabal not working.

Would it suffice if I put a tarball up on github?

Nevermind, I forgot that we did release it after all. I typo'd the search term...

blackgnezdo commented 5 years ago

Thanks for the change!

blackgnezdo commented 5 years ago

@judah do you have the publishing recipe handy?

yorickvP commented 5 years ago

If you're changing things on hackage, you should probably also remove tensorflow-mnist and tensorflow-mnist-input-data. It's not useful to have them available as packages

judah commented 5 years ago

I haven't touched this in a while, but I assume that the stack upload command should do the right thing for this project.

yorickvP commented 5 years ago

You'll need to update some version numbers and maybe constraints, too.

On Tue, Sep 3, 2019, 22:29 Judah Jacobson notifications@github.com wrote:

I haven't touched this in a while, but I assume that the stack upload command should do the right thing for this project.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tensorflow/haskell/pull/247?email_source=notifications&email_token=AAE57JBX64NRU4YPF6MBLFDQH3CLFA5CNFSM4IS36ZN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5ZPCKA#issuecomment-527626536, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE57JEFWW4N6X2V5JVPGZTQH3CLFANCNFSM4IS36ZNQ .

blackgnezdo commented 5 years ago

I uploaded a bunch of new packages. Let me know if anything is missing.