search

tensorflow / java

Java bindings for TensorFlow
Apache License 2.0
785 stars 193 forks source link

Interface should be public for external usage #522

Closed nfeybesse closed 4 months ago

google-cla[bot] commented 4 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Craigacp commented 4 months ago

@nfeybesse once you've signed the CLA we can run the CI and get this merged in.

nfeybesse commented 4 months ago

Hello, I signed the CLA yesterday normally

karllessard commented 4 months ago

Hey @nfeybesse , you got some spotless checks errors being raised by the CI/CD. It is possible that you are not the author of the errors, though as soon as a file is touched and has never been scanned before with spotless, errors are raised.

Can you please run mvn spotless:apply at the root of your project and push the changes?

nfeybesse commented 4 months ago

I seem to have already done this, the command was executed successfully and nothing was modified. I will confirm tomorrow

karllessard commented 4 months ago

I seem to have already done this, the command was executed successfully and nothing was modified. I will confirm tomorrow

I can already see a few non-compliant syntax, including missing spaces, missing braces, etc. Something you can do to help is to enable the Google Java Format in your IDE (if it is IntelliJ, there is a plugin for that).

Craigacp commented 4 months ago

Thanks!