search

tensorflow / java

Java bindings for TensorFlow
Apache License 2.0
813 stars 200 forks source link

Pom profile changes #525

Closed Craigacp closed 6 months ago

Craigacp commented 7 months ago

Switch tensorflow-core-platform so it's only generated when the deploying profile is set. Lets the profiles default through so the platform has the correct values when pulled in without any profiles activated.

saudet commented 7 months ago

As I pointed out before, this isn't going to work with other tools than Maven...

Craigacp commented 7 months ago

It worked when we tested it with gradle earlier today as it defaults in the pom and platform pulls in all the dependencies.

karllessard commented 7 months ago

As I pointed out before, this isn't going to work with other tools than Maven...

The new strategy here @saudet is that we'll build tensorflow-core-platform only when releasing TFJava as part of the CI/CD. The local build will skip it, hence removing the need of playing with platform properties like we were doing originally.

saudet commented 7 months ago

Yeah, sure, feel free to experiment, but do test with other tools is all I can recommend. In the end, I think you'll find the the way I'm doing it in the presets is the least worst