Adding casts to the if test so it passes on GPU

tensorflow / java

Java bindings for TensorFlow

Apache License 2.0

785 stars 193 forks source link

Adding casts to the if test so it passes on GPU #528

Closed Craigacp closed 3 months ago

Craigacp commented 4 months ago

ops.math.neg causes eigen to segfault on GPUs now we've upgraded to TF 2.15. This PR fixes the one test where we do that so that there are casts around it. Not sure how to indicate that users shouldn't use this op on GPU as the op definition accepts ints and it's autogenerated.

karllessard commented 3 months ago

Was this reported to TF core? Or is it an eigen problem?

karllessard commented 3 months ago

As we plan to upgrade to TF2.16, let see if the bug is still there before merging this

Craigacp commented 3 months ago

The if test without this patch still fails on GPU with TF 2.16 (#531).