search

tensorflow / lattice

Lattice methods in TensorFlow
Apache License 2.0
518 stars 93 forks source link

Drop missing input values from the initial input keypoints. #18

Closed si-you closed 6 years ago

mmilanifard commented 6 years ago

Missing values are the only reasonable values that might need removing from the input values. Why not just pass missing values map to the initializer? The code is already somewhat confusing, so I'd rather not add a new concept.

mmilanifard commented 6 years ago

Once again, thanks for the contribution.

si-you commented 6 years ago

Sure. I updated code so please take a look :).

mmilanifard commented 6 years ago

Thanks for the update. Might take a bit to merge internally and here.