tensorflow / lattice

Lattice methods in TensorFlow
Apache License 2.0
518 stars 94 forks source link

uci_census.py with calibrated_dnn fails #29

Closed adrianomoala closed 5 years ago

adrianomoala commented 5 years ago

Hi, first of all I would like to say that TF Lattice is amazing, thanks!!!.

I've tried to run uci_census.py and it works perfectly with all types of models, but 'calibrated_dnn'.

The error happened at line 420: (output, , , regularization) = tfl.input_calibration_layer_from_hparams( features, feature_columns, hparams, quantiles_dir)

I inspected the function tfl.input_calibration_layer_from_hparams and it expects only columns_to_tensor and hparams, but the line 420 provides 3 parameters (features, feature_columns, hparams)

I used pip and by default it installs tensorflow==1.11 and tensorflow_lattice==0.98.

Thanks

mmilanifard commented 5 years ago

Thanks for reporting this. We changed the API a few months ago, but forgot to update the example code. A fix is coming up in the next release (with TF 1.12).

adrianomoala commented 5 years ago

Ok, thanks.