search

tensorflow / lattice

Lattice methods in TensorFlow
Apache License 2.0
518 stars 94 forks source link

Grammar error #60

Closed tojkuv closed 3 years ago

tojkuv commented 3 years ago

_lattice/docs/tutorials/shapeconstraints.ipynb

under Shape Constraints in Diminishing Returns

It should read: Diminishing returns means that the marginal gain of increasing a certain feature value will decrease as we increase the value.

Not this: Diminishing returns means that the marginal gain of increasing certain a feature value will decrease as we increase the value.

It's not a big deal but i was really confused for a minute trying to understand what it meant. Also is there a better place to bring up minor things like this?

mmilanifard commented 3 years ago

Thanks for reporting. The fix will show up in the next release.