tensorflow / lattice

Lattice methods in TensorFlow
Apache License 2.0
518 stars 94 forks source link

setup.py fix sklearn → scikit-learn #68

Closed maresb closed 3 years ago

maresb commented 3 years ago

The package name is scikit-learn while the import is sklearn.

See https://pypi.org/project/sklearn/ for the official recommendation.

Requiring sklearn can lead to subtle problems as explained in https://github.com/scikit-learn/scikit-learn/issues/8215 .

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

maresb commented 3 years ago

@googlebot I signed it!

mmilanifard commented 3 years ago

Thanks for the fix. Unfortunately we do not accept pull requests as our code release process cannot accommodate them at the moment. We will apply the fix and link to this pull request in the notes.

maresb commented 3 years ago

No problem, thanks @mmilanifard!

maresb commented 2 years ago

I see that this has been fixed in v2.0.9. Thank you!