search

tensorflow / lattice

Lattice methods in TensorFlow
Apache License 2.0
518 stars 94 forks source link

Refactoring code for better vectorization #73

Closed maldil closed 2 years ago

maldil commented 2 years ago

Thank you very much for your excellent work in tensorflow/lattice.

I am a graduate student at the University of Colorado, studying the best practices of evolving ML codes. From our research, one of the most common evolution best practice in ML code is the migration of loop-based computations, since it improves performance and code quality. We made the following changes in tensorflow/lattice, which remove the FOR loop and use NumPy APIs. I carefully checked the modification to ensure that it does not break the code. I will gladly contribute. Please help me to merge this.

mmilanifard commented 2 years ago

Thanks a lot for your contribution. We do not accept direct pull requests for this repo due to complications with the release process. We will apply your change internally citing you and this pull request in the change description. We will also apply the change to the other test that include this function.

maldil commented 2 years ago

Superb. Thank you.